shithub: puzzles

Download patch

ref: b732fda2cf611b6f67c68e3a26077897afe41741
parent: 3189fb484dcfe4efe42b2b30e529389db9dd0d00
author: Simon Tatham <[email protected]>
date: Wed Nov 7 14:16:00 EST 2018

Undead: remove an unused structure field.

I noticed that state->common, which is shared between all the game
states in an undo chain, has a 'solved' flag in it. That's not right -
solvedness as a property of a particular state on the chain belongs in
the game_state itself, and having-at-one-point-been-solved-ness as a
persistent property of the whole chain belongs in the game_ui.

Fortunately, the game isn't actually doing it wrong:
state->common->solved is set once and then never read, so it must have
been left in from early abandoned code. Now removed.

--- a/undead.c

+++ b/undead.c

@@ -225,7 +225,6 @@

     int *grid;

     int *xinfo;

     int *fixed;

-    int solved;

 };

 struct game_state {

@@ -260,7 +259,6 @@

     state->common->grid = snewn(state->common->wh, int);

     state->common->xinfo = snewn(state->common->wh, int);

     state->common->fixed = NULL;

-    state->common->solved = FALSE;

     state->common->num_paths =

         state->common->params.w + state->common->params.h;