shithub: puzzles

Download patch

ref: 5c36e1536a05abf514b09476813cf71bc9dc1e31
parent: d5ec2758ee3b7a8934475a1122813ad2312dc850
author: Ben Harris <[email protected]>
date: Tue Jan 10 15:41:24 EST 2023

Last-ditch maximum size limit for Signpost

This makes sure that width * height <= INT_MAX, which it rather needs
to be.

--- a/signpost.c
+++ b/signpost.c
@@ -7,6 +7,7 @@
 #include <string.h>
 #include <assert.h>
 #include <ctype.h>
+#include <limits.h>
 #include <math.h>
 
 #include "puzzles.h"
@@ -421,6 +422,8 @@
 {
     if (params->w < 1) return "Width must be at least one";
     if (params->h < 1) return "Height must be at least one";
+    if (params->w > INT_MAX / params->h)
+        return "Width times height must not be unreasonably large";
     if (full && params->w == 1 && params->h == 1)
 	/* The UI doesn't let us move these from unsolved to solved,
 	 * so we disallow generating (but not playing) them. */