shithub: puzzles

Info  •  Files  •  Log  •  Branches

Fix memory leak in midend_game_id_int()

The "par" string wasn't getting freed on some error paths.  Fixed by
freeing it immediately after its last use, which is before any of the
error paths.

--- a/midend.c

+++ b/midend.c

@@ -1801,6 +1801,7 @@

             newcurparams = me->ourgame->default_params();

         }

         me->ourgame->decode_params(newcurparams, par);

+        sfree(par);

         error = me->ourgame->validate_params(newcurparams, desc == NULL);

         if (error) {

             me->ourgame->free_params(newcurparams);

@@ -1875,8 +1876,6 @@

         me->seedstr = dupstr(seed);

         me->genmode = GOT_SEED;

     }

-

-    sfree(par);

     me->newgame_can_store_undo = false;