shithub: dav1d

Info  •  Files  •  Log  •  Branches

Fix potential memory leak

In the (very unlikely) scenario of a pthread mutex/cond init failure
in the tile state reallocation code some newly allocated mutexes/conds
could leak.

--- a/src/decode.c

+++ b/src/decode.c

@@ -2624,7 +2624,7 @@

             Dav1dTileState *ts_new = realloc(f->ts, sizeof(*f->ts) * n_ts);

             if (!ts_new) goto error;

             f->ts = ts_new;

-            for (int n = f->n_ts; n < n_ts; n++) {

+            for (int n = f->n_ts; n < n_ts; f->n_ts = ++n) {

                 Dav1dTileState *const ts = &f->ts[n];

                 if (pthread_mutex_init(&ts->tile_thread.lock, NULL)) goto error;

                 if (pthread_cond_init(&ts->tile_thread.cond, NULL)) {

@@ -2632,7 +2632,6 @@

                     goto error;

                 }

             }

-            f->n_ts = n_ts;

         } else {

             for (int n = n_ts; n < f->n_ts; n++) {

                 Dav1dTileState *const ts = &f->ts[n];