shithub: pplay

Info  •  Files  •  Log  •  Branches

really decouple drawing samples from playback, fix graphics glitch at startup

apparently the last change there didn't really fix anything, despite full
conviction that the solution was arrived at and observed.  very me!
this patch fixes it all.

--- a/draw.c

+++ b/draw.c

@@ -39,9 +39,10 @@

 	for(;;){

 		recvul(drawc);

-		lockdisplay(display);

 again:

+		lockdisplay(display);

 		draw(viewbg, viewbg->r, display->black, nil, ZP);

+		unlockdisplay(display);

 		n = viewe - views;

 		/*if(!file)*/

 			p = pcmbuf + views;

@@ -81,12 +82,13 @@

 				x+1, bgscalyl - lmin / bgscalf);

 			r = Rect(x, bgscalyr - rmax / bgscalf,

 				x+1, bgscalyr - rmin / bgscalf);

+		lockdisplay(display);

 			draw(viewbg, l, col[Csamp], nil, ZP);

+		unlockdisplay(display);

 			if(stereo)

 				draw(viewbg, r, col[Csamp], nil, ZP);

 			x++;

 		}

-		unlockdisplay(display);

 	}

 }

@@ -244,7 +246,7 @@

 	viewr = rectsubpt(screen->r, screen->r.min);

 	freeimage(viewbg);

 	freeimage(view);

-	viewbg = eallocimage(viewr, 0, DNofill);

+	viewbg = eallocimage(viewr, 0, DBlack);

 	view = eallocimage(viewr, 0, DBlack);

 	if(stereo){

 		midr = viewr;

@@ -297,7 +299,7 @@

 	col[Cline] = eallocimage(Rect(0,0,1,1), 1, 0x884400FF);

 	col[Cloop] = eallocimage(Rect(0,0,1,1), 1, 0x777777FF);

 	loope = filesz;

-	if((drawc = chancreate(sizeof(ulong), 0)) == nil)

+	if((drawc = chancreate(sizeof(ulong), 4)) == nil)

 		sysfatal("chancreate: %r");

 	if(proccreate(drawsamps, nil, mainstacksize) < 0)

 		sysfatal("proccreate: %r");