shithub: opus

Info  •  Files  •  Log  •  Branches

Using OPUS_MOVE() instead of OPUS_COPY() to move redundancy bytes

memcpy() aliasing bug caught by Felicia's encoder fuzzing test

--- a/src/opus_encoder.c

+++ b/src/opus_encoder.c

@@ -2196,7 +2196,7 @@

            /* Put CELT->SILK redundancy data in the right place. */

            if (redundancy && celt_to_silk && st->mode==MODE_HYBRID && st->use_vbr)

            {

-              OPUS_COPY(data+ret, data+nb_compr_bytes, redundancy_bytes);

+              OPUS_MOVE(data+ret, data+nb_compr_bytes, redundancy_bytes);

               nb_compr_bytes = nb_compr_bytes+redundancy_bytes;

            }

         }