shithub: mc

Info  •  Files  •  Log  •  Branches

Use a signed int when we check for <0

    If we use negative value to signal errors, we had better make
    sure that we can hold negative values.

--- a/libstd/intparse.myr

+++ b/libstd/intparse.myr

@@ -45,7 +45,8 @@

 generic doparse = {s, isneg, base

 	var c

-	var v, cv

+	var v

+	var cv : int32

 	v = 0

 	while s.len != 0

@@ -56,7 +57,7 @@

 		cv = charval(c, base)

 		if cv >= 0

 			v *= (base castto(@a::(integral,numeric)))

-			v += cv

+			v += cv castto(@a::(integral,numeric))

 		else

 			-> `None

 		;;