shithub: git9

Info  •  Files  •  Log  •  Branches

git/log: correct heap indexing.

fencepost errors suck, and translating 1-indexing
pseudocode to 0-indexed real code is a pain.

--- a/log.c

+++ b/log.c

@@ -198,13 +198,13 @@

 		heap = earealloc(heap, heapsz, sizeof(Object*));

 	}

 	heap[nheap++] = o;

-	for(i = nheap - 1; i > 0; i /= 2){

+	for(i = nheap - 1; i > 0; i = (i-1)/2){

 		o = heap[i];

 		p = heap[(i-1)/2];

 		if(o->commit->mtime < p->commit->mtime)

 			break;

 		heap[i] = p;

-		heap[i/2] = o;

+		heap[(i-1)/2] = o;

 	}

 }