shithub: riscv

Info  •  Files  •  Log  •  Branches

sshfs: fix dir2attrib() memory leak in wstat error case (thanks BurnZeZ)

--- a/sys/src/cmd/sshfs.c

+++ b/sys/src/cmd/sshfs.c

@@ -569,7 +569,7 @@

 	int uid, gid;

 	werrstr("phase error");

-	r = emalloc9p(MAXATTRIB);

+	*rp = r = emalloc9p(MAXATTRIB);

 	e = r + MAXATTRIB;

 	fl = 0;

 	p = r + 4;

@@ -604,7 +604,6 @@

 		rc = pack(p, e - p, "uu", d->atime, d->mtime); if(rc < 0) return -1; p += rc;

 	}

 	PUT4(r, fl);

-	*rp = r;

 	return p - r;

 }

@@ -929,6 +928,7 @@

 			if(x < 0){

 				responderror(r->req);

 				putsreq(r);

+				free(s);

 				break;

 			}

 			rlock(sf);