shithub: rgbds

Info  •  Files  •  Log  •  Branches

Change the start position check on INCBIN

Currently INCBIN gives an error if your start position == file size.
This means you cannot include an empty file.
It also means the text of the error message is incorrect
(as the start is not greater, but equal to the length of the file)

--- a/src/asm/section.c

+++ b/src/asm/section.c

@@ -774,7 +774,7 @@

 	if (fseek(f, 0, SEEK_END) != -1) {

 		fsize = ftell(f);

-		if (startPos >= fsize) {

+		if (startPos > fsize) {

 			error("Specified start position is greater than length of file\n");

 			fclose(f);

 			return;

@@ -841,7 +841,7 @@

 	if (fseek(f, 0, SEEK_END) != -1) {

 		fsize = ftell(f);

-		if (start_pos >= fsize) {

+		if (start_pos > fsize) {

 			error("Specified start position is greater than length of file\n");

 			return;

 		}