shithub: rgbds

Download patch

ref: 877e0e0b91ea573341597e23706a4a0c22cb1f32
parent: da1d9f68c7bd18b1d8838d98b77276a08152bf29
author: ISSOtm <[email protected]>
date: Mon Feb 3 10:11:19 EST 2020

Get rid of `BANK_COUNT_*` symbols

They weren't used save for the definitions right below, so Occam's razor applies

--- a/include/linkdefs.h
+++ b/include/linkdefs.h
@@ -15,34 +15,6 @@
 #define RGBDS_OBJECT_VERSION_STRING "RGB%1hhu"
 #define RGBDS_OBJECT_VERSION_NUMBER (uint8_t)6
 
-#define BANK_COUNT_ROM0  1
-#define BANK_COUNT_ROMX  511
-#define BANK_COUNT_VRAM  2
-#define BANK_COUNT_SRAM  16
-#define BANK_COUNT_WRAM0 1
-#define BANK_COUNT_WRAMX 7
-#define BANK_COUNT_OAM   1
-#define BANK_COUNT_HRAM  1
-
-enum eBankGBCount {
-	BANK_MIN_ROM0  = 0,
-	BANK_MAX_ROM0  = BANK_COUNT_ROM0  + BANK_MIN_ROM0  - 1,
-	BANK_MIN_ROMX  = 1,
-	BANK_MAX_ROMX  = BANK_COUNT_ROMX  + BANK_MIN_ROMX  - 1,
-	BANK_MIN_WRAM0 = 0,
-	BANK_MAX_WRAM0 = BANK_COUNT_WRAM0 + BANK_MIN_WRAM0 - 1,
-	BANK_MIN_WRAMX = 1,
-	BANK_MAX_WRAMX = BANK_COUNT_WRAMX + BANK_MIN_WRAMX - 1,
-	BANK_MIN_VRAM  = 0,
-	BANK_MAX_VRAM  = BANK_COUNT_VRAM  + BANK_MIN_VRAM  - 1,
-	BANK_MIN_OAM   = 0,
-	BANK_MAX_OAM   = BANK_COUNT_OAM   + BANK_MIN_OAM   - 1,
-	BANK_MIN_HRAM  = 0,
-	BANK_MAX_HRAM  = BANK_COUNT_HRAM  + BANK_MIN_HRAM  - 1,
-	BANK_MIN_SRAM  = 0,
-	BANK_MAX_SRAM  = BANK_COUNT_SRAM  + BANK_MIN_SRAM  - 1
-};
-
 enum RPNCommand {
 	RPN_ADD		= 0x00,
 	RPN_SUB		= 0x01,
@@ -118,6 +90,23 @@
 
 	PATCHTYPE_INVALID
 };
+
+#define BANK_MIN_ROM0  0
+#define BANK_MAX_ROM0  0
+#define BANK_MIN_ROMX  1
+#define BANK_MAX_ROMX  511
+#define BANK_MIN_VRAM  0
+#define BANK_MAX_VRAM  1
+#define BANK_MIN_SRAM  0
+#define BANK_MAX_SRAM  15
+#define BANK_MIN_WRAM0 0
+#define BANK_MAX_WRAM0 0
+#define BANK_MIN_WRAMX 1
+#define BANK_MAX_WRAMX 7
+#define BANK_MIN_OAM   0
+#define BANK_MAX_OAM   0
+#define BANK_MIN_HRAM  0
+#define BANK_MAX_HRAM  0
 
 extern uint16_t startaddr[];
 extern uint16_t maxsize[];