shithub: cstory

Info  •  Files  •  Log  •  Branches

Made signed chars explicit

The default sign varies between hardware.

Text seems to always be ambiguously 'char', so I've left those

--- a/src/Fade.cpp

+++ b/src/Fade.cpp

@@ -16,9 +16,9 @@

 	int mode;

 	BOOL bMask;

 	int count;

-	char ani_no[FADE_HEIGHT][FADE_WIDTH];

-	char flag[FADE_HEIGHT][FADE_WIDTH];	// Not a BOOLEAN (those are unsigned)

-	char dir;

+	signed char ani_no[FADE_HEIGHT][FADE_WIDTH];

+	signed char flag[FADE_HEIGHT][FADE_WIDTH];	// Not a BOOLEAN (those are unsigned)

+	signed char dir;

 };

 static FADE gFade;

@@ -41,7 +41,7 @@

 	gFade.mode = 0;

 }

-void StartFadeOut(char dir)

+void StartFadeOut(signed char dir)

 {

 	gFade.mode = 2;

 	gFade.count = 0;

@@ -58,7 +58,7 @@

 	}

 }

-void StartFadeIn(char dir)

+void StartFadeIn(signed char dir)

 {

 	int x;

 	int y;

--- a/src/Fade.h

+++ b/src/Fade.h

@@ -5,8 +5,8 @@

 void InitFade();

 void SetFadeMask();

 void ClearFade();

-void StartFadeOut(char dir);

-void StartFadeIn(char dir);

+void StartFadeOut(signed char dir);

+void StartFadeIn(signed char dir);

 void ProcFade();

 void PutFade();

 BOOL GetFadeActive();

--- a/src/Organya.cpp

+++ b/src/Organya.cpp

@@ -303,7 +303,7 @@

 	lpDRAMBUFFER[track]->SetVolume((volume - 0xFF) * 8);

 }

-void PlayDramObject(unsigned char key, int mode,char track)

+void PlayDramObject(unsigned char key, int mode, signed char track)

 {

 	switch(mode)

 	{

--- a/src/PixTone.cpp

+++ b/src/PixTone.cpp

@@ -56,7 +56,7 @@

 	// White noise wave

 	rep_srand(0);

 	for (i = 0; i < 256; ++i)

-		gWaveModelTable[5][i] = (char)(rep_rand() & 0xFF) / 2;

+		gWaveModelTable[5][i] = (signed char)(rep_rand() & 0xFF) / 2;

 }

 BOOL MakePixelWaveData(const PIXTONEPARAMETER *ptp, unsigned char *pData)

--- a/src/Profile.h

+++ b/src/Profile.h

@@ -25,7 +25,7 @@

 	ARMS arms[8];

 	ITEM items[32];

 	PERMIT_STAGE permitstage[8];

-	char permit_mapping[0x80];

+	signed char permit_mapping[0x80];

 	char FLAG[4];

 	uint8_t flags[1000];

 };

--- a/src/Stage.h

+++ b/src/Stage.h

@@ -10,7 +10,7 @@

 	char back[0x20];

 	char npc[0x20];

 	char boss[0x20];

-	char boss_no;

+	signed char boss_no;

 	char name[0x20];

 };

--- a/src/TextScr.h

+++ b/src/TextScr.h

@@ -16,10 +16,10 @@

 	char *data;

 	//Mode (ex. NOD, WAI)

-	char mode;

+	signed char mode;

 	//Flags

-	char flags;

+	signed char flags;

 	//Current positions (read position in buffer, x position in line)

 	unsigned int p_read;

@@ -37,7 +37,7 @@

 	int next_event;

 	//Yes/no selected

-	char select;

+	signed char select;

 	//Current face

 	int face;