shithub: choc

Download patch

ref: 5fcd4dc343af24dbcfa1896936d1e8fd1c12d236
parent: 6ee44d364659f1d2b4c43c2bdad276c667ae1907
author: James Haley <[email protected]>
date: Thu Oct 6 07:33:11 EDT 2011

Fix for missing finale fade-to-black bug that was driving me nuts - one
of the last known inaccuracies not related to the multiplayer code.
Missing dirty rects system strikes again, basically.

Subversion-branch: /branches/v2-branch
Subversion-revision: 2409

--- a/src/strife/f_finale.c
+++ b/src/strife/f_finale.c
@@ -173,7 +173,10 @@
 //
 void F_StartFinale (void)
 {
+#if 0
+    // haleyjd 20111006: see below...
     patch_t *panel;
+#endif
 
     gameaction = ga_nothing;
     gamestate = GS_FINALE;
@@ -184,8 +187,16 @@
     // [STRIFE] Setup the slide show
     slideshow_panel = DEH_String("PANEL0");
 
+    // haleyjd 20111006: These two lines of code *are* in vanilla Strife; 
+    // however, there, they were completely inconsequential due to the dirty
+    // rects system. No intervening V_MarkRect call means PANEL0 was never 
+    // drawn to the framebuffer. In Chocolate Strife, however, with no such
+    // system in place, this only manages to fuck up the fade-out that is
+    // supposed to happen at the beginning of all finales. So, don't do it!
+#if 0
     panel = (patch_t *)W_CacheLumpName(slideshow_panel, PU_CACHE);
     V_DrawPatch(0, 0, panel);
+#endif
 
     switch(gamemap)
     {