ref: fabf026f4937bf6fbbb944aa7d6e721839ae4c92
parent: 94f0f7e59788e802e706a55cac0d52a9e70ff745
author: Bjørn Erik Pedersen <[email protected]>
date: Wed Nov 14 12:44:04 EST 2018
helpers: Add a comment about file mode for new files See #5434
--- a/helpers/path.go
+++ b/helpers/path.go
@@ -563,12 +563,13 @@
func OpenFileForWriting(fs afero.Fs, filename string) (afero.File, error) {
filename = filepath.Clean(filename)
// Create will truncate if file already exists.
+ // os.Create will create any new files with mode 0666 (before umask).
f, err := fs.Create(filename)
if err != nil {
if !os.IsNotExist(err) {
return nil, err
}
- if err = fs.MkdirAll(filepath.Dir(filename), 0777); err != nil { // rwx, rw, r before umask
+ if err = fs.MkdirAll(filepath.Dir(filename), 0777); err != nil { // before umask
return nil, err
}
f, err = fs.Create(filename)