shithub: hugo

Download patch

ref: f08ea02d24d42929676756950f3affaca7fd8c01
parent: 016398ffe2e0a073453cf46a9d6bf72d693c11e5
author: Bjørn Erik Pedersen <[email protected]>
date: Sun Jan 28 12:22:08 EST 2018

commands: Deprecate CLI flags canonifyURLs, pluralizeListTitles, preserveTaxonomyNames, uglyURLs

You can of course still set them in site config.

Fixes #4347

--- a/commands/hugo.go
+++ b/commands/hugo.go
@@ -509,8 +509,21 @@
 
 }
 
+var deprecatedFlags = map[string]bool{
+	strings.ToLower("uglyURLs"):              true,
+	strings.ToLower("pluralizeListTitles"):   true,
+	strings.ToLower("preserveTaxonomyNames"): true,
+	strings.ToLower("canonifyURLs"):          true,
+}
+
 func (c *commandeer) setValueFromFlag(flags *flag.FlagSet, key string) {
 	if flags.Changed(key) {
+		if _, deprecated := deprecatedFlags[strings.ToLower(key)]; deprecated {
+			msg := fmt.Sprintf(`Set "%s = true" in your config.toml.
+If you need to set this configuration value from the command line, set it via an OS environment variable: "HUGO_%s=true hugo"`, key, strings.ToUpper(key))
+			// Remove in Hugo 0.37
+			helpers.Deprecated("hugo", "--"+key+" flag", msg, false)
+		}
 		f := flags.Lookup(key)
 		c.Set(key, f.Value.String())
 	}