shithub: hugo

Info  •  Files  •  Log  •  Branches

Fix section menus for lazy blogger

IsMenuCurrent was always returning false for the top level entries.

Fixes #2065

--- a/hugolib/menu_test.go

+++ b/hugolib/menu_test.go

@@ -435,9 +435,6 @@

 	assert.NotNil(t, fishySectionMenuEntry)

 	assert.NotNil(t, nodeFishy)

-	firstSectionMenuEntry.URL = firstSectionMenuEntry.URL + "/"

-	secondSectionMenuEntry.URL = secondSectionMenuEntry.URL + "/"

-	fishySectionMenuEntry.URL = fishySectionMenuEntry.URL + "/"

 	assert.True(t, nodeFirst.IsMenuCurrent("spm", firstSectionMenuEntry))

 	assert.False(t, nodeFirst.IsMenuCurrent("spm", secondSectionMenuEntry))

 	assert.False(t, nodeFirst.IsMenuCurrent("spm", fishySectionMenuEntry))

--- a/hugolib/site.go

+++ b/hugolib/site.go

@@ -1192,7 +1192,7 @@

 		if sectionPagesMenu != "" {

 			if _, ok := sectionPagesMenus[p.Section()]; !ok {

 				if p.Section() != "" {

-					me := MenuEntry{Identifier: p.Section(), Name: helpers.MakeTitle(helpers.FirstUpper(p.Section())), URL: s.Info.createNodeMenuEntryURL("/" + p.Section())}

+					me := MenuEntry{Identifier: p.Section(), Name: helpers.MakeTitle(helpers.FirstUpper(p.Section())), URL: s.Info.createNodeMenuEntryURL("/" + p.Section() + "/")}

 					if _, ok := flat[twoD{sectionPagesMenu, me.KeyName()}]; ok {

 						// menu with same id defined in config, let that one win

 						continue