shithub: hugo

Info  •  Files  •  Log  •  Branches

tpl/transform: Do not unescape input to highlight

Fixes #4179

--- a/tpl/transform/transform.go

+++ b/tpl/transform/transform.go

@@ -55,7 +55,7 @@

 		return "", err

 	}

-	highlighted, _ := ns.deps.ContentSpec.Highlight(html.UnescapeString(ss), lang, opts)

+	highlighted, _ := ns.deps.ContentSpec.Highlight(ss, lang, opts)

 	return template.HTML(highlighted), nil

 }

--- a/tpl/transform/transform_test.go

+++ b/tpl/transform/transform_test.go

@@ -69,6 +69,8 @@

 		expect interface{}

 	}{

 		{"func boo() {}", "go", "", "boo"},

+		// Issue #4179

+		{`<Foo attr=" &lt; "></Foo>`, "xml", "", `&amp;lt;`},

 		{tstNoStringer{}, "go", "", false},

 	} {

 		errMsg := fmt.Sprintf("[%d]", i)

@@ -81,7 +83,7 @@

 		}

 		require.NoError(t, err, errMsg)

-		assert.Contains(t, result, "boo", errMsg)

+		assert.Contains(t, result, test.expect.(string), errMsg)

 	}

 }