shithub: hugo

Info  •  Files  •  Log  •  Branches

Fix two tests that are broken on Windows

Put guards around TestPageBundlerCaptureSymlinks and
TestPageBundlerSiteWitSymbolicLinksInContent so that they aren't
run on Windows (they both use symbolic links and the Go library
implementation requires administrator mode on Windows).

--- a/hugolib/page_bundler_capture_test.go

+++ b/hugolib/page_bundler_capture_test.go

@@ -22,6 +22,7 @@

 	jww "github.com/spf13/jwalterweatherman"

+	"runtime"

 	"strings"

 	"sync"

 	"testing"

@@ -82,6 +83,10 @@

 }

 func TestPageBundlerCaptureSymlinks(t *testing.T) {

+	if runtime.GOOS == "windows" && os.Getenv("CI") == "" {

+		t.Skip("Skip TestPageBundlerCaptureSymlinks as os.Symlink needs administrator rights on Windows")

+	}

+

 	assert := require.New(t)

 	ps, workDir := newTestBundleSymbolicSources(t)

 	sourceSpec := source.NewSourceSpec(ps, ps.BaseFs.ContentFs)

@@ -92,7 +97,7 @@

 	assert.NoError(c.capture())

-	// Symlik back to content skipped to prevent infinite recursion.

+	// Symlink back to content skipped to prevent infinite recursion.

 	assert.Equal(uint64(3), logger.LogCountForLevelsGreaterThanorEqualTo(jww.LevelWarn))

 	expected := `

--- a/hugolib/page_bundler_test.go

+++ b/hugolib/page_bundler_test.go

@@ -308,6 +308,10 @@

 }

 func TestPageBundlerSiteWitSymbolicLinksInContent(t *testing.T) {

+	if runtime.GOOS == "windows" && os.Getenv("CI") == "" {

+		t.Skip("Skip TestPageBundlerSiteWitSymbolicLinksInContent as os.Symlink needs administrator rights on Windows")

+	}

+

 	assert := require.New(t)

 	ps, workDir := newTestBundleSymbolicSources(t)

 	cfg := ps.Cfg