ref: 096a4b67b98259dabff5ebfbfd879a41999a1ed2
parent: bc70f2bf123d94fc3226754ec9f1f44748e98162
author: Baibhav Vatsa <[email protected]>
date: Thu Oct 10 16:16:15 EDT 2019
tpl: After now accepts 0 as index Modified the if conditional because of which after threw an error if called with 0 as index. The function now returns the whole original slice if 0 is passed as an index. Also added tests to test the new behavior. Fixes #6388
--- a/tpl/collections/collections.go
+++ b/tpl/collections/collections.go
@@ -60,7 +60,7 @@
return nil, err
}
- if indexv < 1 {
+ if indexv < 0 {
return nil, errors.New("can't return negative/empty count of items from sequence")
}
--- a/tpl/collections/collections_test.go
+++ b/tpl/collections/collections_test.go
@@ -50,6 +50,8 @@
{int64(2), []int{100, 200, 300}, []int{300}},
{100, []int{100, 200}, []int{}},
{"1", []int{100, 200, 300}, []int{200, 300}},
+ {0, []int{100, 200, 300, 400, 500}, []int{100, 200, 300, 400, 500}},
+ {0, []string{"a", "b", "c", "d", "e"}, []string{"a", "b", "c", "d", "e"}},
{int64(-1), []int{100, 200, 300}, false},
{"noint", []int{100, 200, 300}, false},
{2, []string{}, []string{}},