shithub: hugo

Info  •  Files  •  Log  •  Branches

Change all uses of sort.Sort to sort.Stable.Using sort.Stable ensures that even if the sort keys are the same, the order of the sort will not randomly change.  Using the old sort.Sort, if you had pages with no date, the lists of those pages would randomly reorder every time you regenerate the list, causing spurious changes to the output.  Now they'll always get ordered in the same way.

--- a/hugolib/menu.go

+++ b/hugolib/menu.go

@@ -129,7 +129,7 @@

 		menu: menu,

 		by:   by, // The Sort method's receiver is the function (closure) that defines the sort order.

 	}

-	sort.Sort(ms)

+	sort.Stable(ms)

 }

 var DefaultMenuEntrySort = func(m1, m2 *MenuEntry) bool {

--- a/hugolib/pageSort.go

+++ b/hugolib/pageSort.go

@@ -35,7 +35,7 @@

 		pages: pages,

 		by:    by, // The Sort method's receiver is the function (closure) that defines the sort order.

 	}

-	sort.Sort(ps)

+	sort.Stable(ps)

 }

 var DefaultPageSort = func(p1, p2 *Page) bool {

--- a/hugolib/taxonomy.go

+++ b/hugolib/taxonomy.go

@@ -134,7 +134,7 @@

 		taxonomy: taxonomy,

 		by:       by, // The Sort method's receiver is the function (closure) that defines the sort order.

 	}

-	sort.Sort(ps)

+	sort.Stable(ps)

 }

 // Len is part of sort.Interface.

@@ -162,7 +162,7 @@

 func (p WeightedPages) Len() int      { return len(p) }

 func (p WeightedPages) Swap(i, j int) { p[i], p[j] = p[j], p[i] }

-func (p WeightedPages) Sort()         { sort.Sort(p) }

+func (p WeightedPages) Sort()         { sort.Stable(p) }

 func (p WeightedPages) Count() int    { return len(p) }

 func (p WeightedPages) Less(i, j int) bool {

 	if p[i].Weight == p[j].Weight {