shithub: freetype+ttf2subf

Info  •  Files  •  Log  •  Branches

* builds/toplevel.mk: Avoid side effects of `shell`.

We use a dummy variable to catch its output.  Otherwise the `make`
program is going to interpret the return value of `shell`; this can
cause obscure warning or error messages or even be harmful.

git/fs: mount .git/fs: mount/attach disallowed

--- a/ChangeLog

+++ b/ChangeLog

@@ -1,5 +1,13 @@

 2021-02-16  Werner Lemberg  <[email protected]>

+	* builds/toplevel.mk: Avoid side effects of `shell`.

+

+	We use a dummy variable to catch its output.  Otherwise the `make`

+	program is going to interpret the return value of `shell`; this can

+	cause obscure warning or error messages or even be harmful.

+

+2021-02-16  Werner Lemberg  <[email protected]>

+

 	Move 'dlg' submodule to `subprojects` directory.

 	This is for future changes with Meson, which doesn't allow a

--- a/builds/toplevel.mk

+++ b/builds/toplevel.mk

@@ -118,17 +118,17 @@

   ifeq ($(wildcard src/dlg/dlg.*),)

     ifeq ($(wildcard subprojects/dlg/*),)

       $(info Checking out submodule in `subprojects/dlg')

-      $(shell git submodule init)

-      $(shell git submodule update)

+      dummy := $(shell git submodule init)

+      dummy := $(shell git submodule update)

     endif

     $(info Copying files from `subprojects/dlg' to `src/dlg' and `include/dlg')

-    $(shell mkdir $(subst /,$(SEP),include/dlg) $(NO_OUTPUT))

-    $(shell $(COPY) \

+    dummy := $(shell mkdir $(subst /,$(SEP),include/dlg) $(NO_OUTPUT))

+    dummy := $(shell $(COPY) \

       $(subst /,$(SEP),subprojects/dlg/include/dlg/output.h include/dlg))

-    $(shell $(COPY) \

+    dummy := $(shell $(COPY) \

       $(subst /,$(SEP),subprojects/dlg/include/dlg/dlg.h include/dlg))

-    $(shell $(COPY) \

+    dummy := $(shell $(COPY) \

       $(subst /,$(SEP),subprojects/dlg/src/dlg/dlg.c src/dlg))

   endif